Add redfishpower HPE Cray EX chassis device file #173

chu11 · 2024-04-05T03:37:23Z

Built on top of #167 and #172, but those don't have to go in first. #167 is a "pretty nice to have" (would like to have before release), #172 can be debated before release if it should go in.

chu11 · 2024-04-08T19:49:14Z

re-pushed, ~~its no longer based on #172, it was far less necessary for this PR compared to #167~~ nevermind, strike that ... i have tests that assume the --diag support :-) ... we can debate if those should be ripped out or not.

chu11 · 2024-04-09T19:53:18Z

re-pushed, rebasing on #172. mostly just updating the tests, "diagnostic" error messages are now by default (no --diag), to stderr, and one per line

garlick · 2024-04-11T01:02:37Z

The dependent PRs are approved so I'll wait to review this until it's rebased on master after those are merged if that's OK.

chu11 · 2024-04-11T05:05:39Z

re-pushed, rebasing on master and fixing up tests given new error message output possibilities

garlick · 2024-04-11T05:40:15Z

For a start, could we just propose the one spec in this PR, for the fully populated chassis, drop the inline documentation, and shorten the name to "cray-ex" or similar?

chu11 · 2024-04-11T17:05:53Z

ok, re-pushed per your comments above. We'll split out rabbit config into it's own PR later.

garlick

So nice to see this coming together!

garlick · 2024-04-11T17:39:58Z

etc/devices/redfishpower-cray-ex.dev

+#   include "/etc/powerman/redfishpower-cray-ex.dev"
+#   device "redfishpower" "redfishpower-CrayEX" "/usr/sbin/redfishpower -h -h cmm0,pmynode[0-15] |&"
+#   node "cmm0,myperif[0-7],myblade[0-7],mynode[0-15]" "redfishpower" "Enclosure,Perif[0-7],Blade[0-7],Node[0-15]"


Is that an extra -h on the device line?

Suggest you don't name the example device "redfishpower" but something more useful like "chassis0".

Finally, since these device lines are going to be repeated quite a lot in a large config, can we shorten the spec name further and drop the capital letters?

E.g. instead of

device "redfishpower" "redfishpower-CrayEX" "/usr/sbin/redfishpower -h -h cmm0,pmynode[0-15] |&"

go with

device "chassis0" "cray-ex" "/usr/sbin/redfishpower -h cmm0,pmynode[0-15] |&"

garlick · 2024-04-11T17:45:48Z

etc/devices/redfishpower-cray-ex.dev

+		send "setplugs Enclosure 0\n"
+		expect "redfishpower> "
+		send "setplugs Perif[0-7],Blade[0-7] 0 Enclosure\n"
+		expect "redfishpower> "


It might improve readability a bit if on the first occurrence of setplugs there was a comment listing the positional arguments, e.g.

# setplugs pluglist hostindex [parent plug]

garlick · 2024-04-11T17:48:12Z

etc/devices/redfishpower-cray-ex.dev

+		send "setpath Enclosure,Perif[0-7],Blade[0-7] stat redfish/v1/Chassis/{{plug}}\n"
+		expect "redfishpower> "
+		send "setpath Enclosure,Perif[0-7],Blade[0-7] on redfish/v1/Chassis/{{plug}}/Actions/Chassis.Reset {\"ResetType\":\"On\"}\n"


Same with setpath e.g.

# setpath pluglist {stat|on|off} path

garlick · 2024-04-11T17:50:42Z

etc/devices/redfishpower-cray-ex.dev

+		send "settimeout 75\n"
+		expect "redfishpower> "


This timeout deserves quick comment too like

# settimeout [seconds] - on/off operations fail on expiration

garlick · 2024-04-11T17:53:38Z

t/t0029-redfish.t

+#
+
+test_expect_success 'create powerman.conf for chassis w/ 16 redfish nodes (crayex)' '
+	cat >powerman_hpe_cray_supercomputing_ex_chassis.conf <<-EOT


This is just a temp file so maybe we could shorten the name a bit :-)

garlick · 2024-04-11T17:57:13Z

t/t0029-redfish.t

+#
+# redfishpower hpe cray supercomputing ex chassis test
+#


This should probably be its own test script since its likely we'll want to add tests as things come up on the real system. Plus it allows for the tests to run in parallel.

good idea, and we can add your "big redfish test" in afterwards. (#127)

chu11 · 2024-04-11T18:37:27Z

re-pushed per comments above!

garlick

Awesome! Just one more thought.

garlick · 2024-04-11T18:50:22Z

etc/devices/redfishpower-cray-ex.dev

+# - If your chassis is not fully populated, put placeholder hosts in
+#   the redfishpower hosts configuration.  Adjust plugs when
+#   configuring specific targets.  For example, let's say perif[4-7]
+#   and blades[4-7] are not populated (thus nodes[8-15] also do not exist).
+#
+#   device "chassis0" "cray-ex" "/usr/sbin/redfishpower -h cmm0,pnode[0-7],unused[0-7] |&"
+#   node "cmm0,myperif[0-3],myblade[0-3],mynode[0-7]" "redfishpower" "Enclosure,Perif[0-3],Blade[0-3],Node[0-7]"
+#


This might be slightly clearer if the example focused on the unused elements of the hostlist. So just depopulate Blade[4-7] hence Node[8-15] and leave Perif[4-7] out of it.

Oh one other quick thing. I assume auth USER:PASS is not the published vendor default password. Do we want to put the default in the dev script ? Then we wouldn't require people to immediatley copy the dev script.

It seems like this came up and we found the default on a public web document somewhere? (need to confirm)

Have to check if this is accurate, but if so, it's out there searchable with a google so IMHO is fair game to include in a dev script.

https://support.hpe.com/hpesc/public/docDisplay?docId=a00117940en_us&docLocale=en_US&page=Manage_System_Passwords.html#redfish-credentials

This might be slightly clearer if the example focused on the unused elements of the hostlist. So just depopulate Blade[4-7] hence Node[8-15] and leave Perif[4-7] out of it.

I guess in my example I wanted to show how to config if switches aren't populated too. Would it be clearer if I did two examples?

Oh one other quick thing. I assume auth USER:PASS is not the published vendor default password. Do we want to put the default in the dev script ? Then we wouldn't require people to immediatley copy the dev script.

Good point!

I guess in my example I wanted to show how to config if switches aren't populated too. Would it be clearer if I did two examples?

Eh, I guess if you want although that part is just standard powerman stuff.

i'm gonna punt on the default username/password to a follow up PR

Eh, I guess if you want although that part is just standard powerman stuff.

Ohhh, i see your point. It's normal powerman conf stuff. makes sense.

chu11 · 2024-04-11T20:36:08Z

re-pushed, tweaking the one thing commented on above. if we decide to change default username/password will put into a follow up PR.

garlick · 2024-04-11T20:40:41Z

etc/devices/redfishpower-cray-ex.dev

+#   are not populated (thus nodes[8-15] also do not exist).
+#
+#   device "chassis0" "cray-ex" "/usr/sbin/redfishpower -h cmm0,pnode[0-7],unused[0-7] |&"
+#   node "cmm0,myperif[0-7],myblade[0-3],mynode[0-7]" "redfishpower" "Enclosure,Perif[0-7],Blade[0-3],Node[0-7]"


device name should be "chassis0" here

garlick · 2024-04-11T20:41:28Z

t/t0037-cray-ex.t

+
+# Use port = 11000 + test number
+# That way there won't be port conflicts with make -j
+testaddr=localhost:11029


should be 11000 + 37 = 11037

Add device file for a HPE Cray Supercomputing EX Chassis. Fixes chaos#128

Problem: There is no testing for the new HPE Cray Supercomputing EX Chassis device file. Add new tests in new t0037-cray-ex.t test file.

chu11 · 2024-04-11T20:43:54Z

doh! good catches ... re-pushed with those two tweaks above

mergify bot mentioned this pull request Apr 5, 2024

WIP redfishpower: support cray supercomputing ex chassis & power control hierarchy #150

Closed

chu11 force-pushed the redfishpower_hpe_cray_ex branch from b95676d to 074be36 Compare April 8, 2024 19:48

chu11 force-pushed the redfishpower_hpe_cray_ex branch 2 times, most recently from e5ef2ba to 85d3660 Compare April 9, 2024 19:28

chu11 force-pushed the redfishpower_hpe_cray_ex branch from 85d3660 to 2faf3a9 Compare April 11, 2024 05:05

chu11 force-pushed the redfishpower_hpe_cray_ex branch from 2faf3a9 to 118a764 Compare April 11, 2024 17:05

chu11 force-pushed the redfishpower_hpe_cray_ex branch from 118a764 to 4def2a9 Compare April 11, 2024 17:08

garlick reviewed Apr 11, 2024

View reviewed changes

chu11 force-pushed the redfishpower_hpe_cray_ex branch from 4def2a9 to de6f32b Compare April 11, 2024 18:36

garlick approved these changes Apr 11, 2024

View reviewed changes

chu11 force-pushed the redfishpower_hpe_cray_ex branch from de6f32b to 01e9953 Compare April 11, 2024 20:35

chu11 added the merge-when-passing label Apr 11, 2024

garlick reviewed Apr 11, 2024

View reviewed changes

chu11 removed the merge-when-passing label Apr 11, 2024

garlick reviewed Apr 11, 2024

View reviewed changes

chu11 added 2 commits April 11, 2024 13:43

etc: add device file for HPE Cray EX Chassis

7443e9b

Add device file for a HPE Cray Supercomputing EX Chassis. Fixes chaos#128

t: test hpe cray supercomputing ex chassis device

c951691

Problem: There is no testing for the new HPE Cray Supercomputing EX Chassis device file. Add new tests in new t0037-cray-ex.t test file.

chu11 force-pushed the redfishpower_hpe_cray_ex branch from 01e9953 to c951691 Compare April 11, 2024 20:43

chu11 added the merge-when-passing label Apr 11, 2024

mergify bot merged commit 5f76e98 into chaos:master Apr 11, 2024
8 checks passed

chu11 deleted the redfishpower_hpe_cray_ex branch April 12, 2024 00:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add redfishpower HPE Cray EX chassis device file #173

Add redfishpower HPE Cray EX chassis device file #173

chu11 commented Apr 5, 2024 •

edited

Loading

chu11 commented Apr 8, 2024 •

edited

Loading

chu11 commented Apr 9, 2024

garlick commented Apr 11, 2024

chu11 commented Apr 11, 2024

garlick commented Apr 11, 2024

chu11 commented Apr 11, 2024

garlick left a comment

garlick Apr 11, 2024

garlick Apr 11, 2024

garlick Apr 11, 2024

garlick Apr 11, 2024

garlick Apr 11, 2024

garlick Apr 11, 2024 •

edited

Loading

chu11 Apr 11, 2024

chu11 commented Apr 11, 2024

garlick left a comment

garlick Apr 11, 2024

garlick Apr 11, 2024

garlick Apr 11, 2024 •

edited

Loading

chu11 Apr 11, 2024

garlick Apr 11, 2024

chu11 Apr 11, 2024

chu11 Apr 11, 2024

chu11 commented Apr 11, 2024

garlick Apr 11, 2024

garlick Apr 11, 2024

chu11 commented Apr 11, 2024

Add redfishpower HPE Cray EX chassis device file #173

Add redfishpower HPE Cray EX chassis device file #173

Conversation

chu11 commented Apr 5, 2024 • edited Loading

chu11 commented Apr 8, 2024 • edited Loading

chu11 commented Apr 9, 2024

garlick commented Apr 11, 2024

chu11 commented Apr 11, 2024

garlick commented Apr 11, 2024

chu11 commented Apr 11, 2024

garlick left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

garlick Apr 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chu11 commented Apr 11, 2024

garlick left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

garlick Apr 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chu11 commented Apr 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chu11 commented Apr 11, 2024

chu11 commented Apr 5, 2024 •

edited

Loading

chu11 commented Apr 8, 2024 •

edited

Loading

garlick Apr 11, 2024 •

edited

Loading

garlick Apr 11, 2024 •

edited

Loading