redfishpower: output more detailed error messages #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garlick
reviewed
Apr 27, 2024
src/redfishpower/redfishpower.c
Outdated
Comment on lines
1592
to
1595
| if (cmsg->data.result == CURLE_COULDNT_CONNECT) | ||
| printf("%s: %s\n", pm->plugname, "couldn't connect"); | ||
| else if (cmsg->data.result == CURLE_OPERATION_TIMEDOUT) | ||
| printf("%s: %s\n", pm->plugname, "operation timedout"); |
There was a problem hiding this comment.
Would this be useful instead?
There was a problem hiding this comment.
Ahhh good idea, although b/c this is CURLcode not CURLMcode
https://curl.se/libcurl/c/curl_multi_info_read.html
we gotta use a slightly different function.
Problem: Redfishpower decided to output a generic "network error" message when either a connection error occurred (i.e. typically if the host is down) vs a operation timeout (i.e. such as a failed DNS lookup). All other errors are generically output as "error". It would be useful to know which one actually happened. Call curl_easy_strerror() on the error, to get the appropriate error message for the error code.
chu11
force-pushed
the
redfishpower_error_messages
branch
from
fd85cbe
to
2946b1e
Compare
chu11
changed the title
|
re-pushed going with calling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Redfishpower decided to output a generic "network error" message when either a connection error occurred (i.e. typically if the host is down) vs a operation timeout (i.e. such as a failed DNS lookup). It would be useful to know which one actually happened.
Split the "network error" message into two specific error messages.