testsuite: skip huge test unless requested #210
Conversation
|
oops might need to do this another way |
|
Switched the prereq to EXPENSIVE (the correct prereq name to go with TEST_LONG) and also let the test run if GITHUB_CI is set in the environment, then set that in the workflow. |
There was a problem hiding this comment.
lgtm, although I'd recommend adding a comment to t0039 that says set TEST_LONG=1 ... to run. I know I'm going to see that prereq check and do EXPENSIVE=1 make check and be confused why it didn't work :-)
Edit: I guess optionally could do a README.md as well to list testing notes / quirks. But not sure if this is alone crosses the threshold to start a README.md. Up to you :-)
|
Sure I'll add that and then set MWP. Thanks! |
Problem: the debian riscv64 build environment is failing on the el capitan scaling test. We don't have detailed test output to diagnose the failure but we can probably assume that this is a fairly under-powered builder. Set the EXPENSIVE built-in test prereq so that this test only runs if TEST_LONG is set in the environment or the --long test option is given. To avoid losing coverage in github CI, also allow the test to run if GITHUB_CI is set in the environment, and then set it where the workflow runs make check. Fixes chaos#206 more
Problem: the debian riscv64 build environment is failing on the el capitan scaling test.
We don't have detailed test output to diagnose the failure but we can probably assume that this is a fairly under-powered builder.
Disable the test unless TEST_LONG is set in the test environment. Set TEST_LONG when the github workflow runs make check, so we won't lose this coverage in github CI.
Fixes #206