Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etc: fix logic error in redfishpower cray windom #70

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

chu11
Copy link
Member

@chu11 chu11 commented Jan 20, 2024

Problem: The cycle_ranged logic in redfishpower-cray-windom.dev is backwards, issuing an "on" before an "off". It should be the other way around.

Solution: Perform an off and then an on for cycle_ranged.

Fixes #69

Problem: The cycle_ranged logic in redfishpower-cray-windom.dev is
backwards, issuing an "on" before an "off".  It should be the other
way around.

Solution: Perform an off and then an on for cycle_ranged.

Fixes chaos#69
Copy link
Member

@garlick garlick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chu11 chu11 merged commit a7bcc49 into chaos:master Jan 23, 2024
4 checks passed
@chu11 chu11 deleted the redfishpower_cycle branch January 23, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redfishpower-cray-windom.dev: cycle is backwards
2 participants