Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix redfishpower tests #71

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Conversation

chu11
Copy link
Member

@chu11 chu11 commented Jan 21, 2024

Problem: redfishpower was inadvertently not tested because the test
configuration copy and pasted "ipmipower" and never changed it.

Update test to use redfishpower instead of ipmipower.

Problem: Several newer tests were not added to the check_DATA target
in the Makefile.

Add missing tests.
Problem: redfishpower was inadvertently not tested because the test
configuration copy and pasted "ipmipower" and never changed it.

Update test to use redfishpower instead of ipmipower.
Copy link
Member

@garlick garlick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chu11 chu11 merged commit ad3a31a into chaos:master Jan 23, 2024
4 checks passed
@garlick
Copy link
Member

garlick commented Jan 23, 2024

I think that should have been rebased on current master first. We're kind of used to mergify doing that for us in flux-core. I added that to the "hackathon wishlist".

@chu11
Copy link
Member Author

chu11 commented Jan 23, 2024

I think that should have been rebased on current master first. We're kind of used to mergify doing that for us in flux-core. I added that to the "hackathon wishlist".

Oops, I'm sorry. I saw github's merge button spinning and doing stuff, I thought it did it for me. I now see there's a "rebase and merge" button I should have used.

@chu11 chu11 deleted the redfishpower_tests branch January 23, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants