Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added KVM dev files. #8

Merged
merged 1 commit into from
Jan 31, 2016
Merged

Added KVM dev files. #8

merged 1 commit into from
Jan 31, 2016

Conversation

adduty
Copy link

@adduty adduty commented Jan 22, 2016

Added dev files for controlling power to virtual machines running on a
KVM (Kernel-based Virtual Machine) hypervisor, kvm.dev for a local
hypervisor and kvm-ssh for a remote hypervisor.

@garlick
Copy link
Member

garlick commented Jan 22, 2016

Nice! Couple fixes needed:

  • The kvm.dev needs its specification name changed to "kvm". Its header comment says its for ssh too.
  • The new dev files should be added to etc/Makefile.am

If you can fix those, rebase, and force a push, I think this can go in.

Thanks!

@adduty
Copy link
Author

adduty commented Jan 26, 2016

I think I have done this successfully. I am new to git as well as github
(I'm coming from mercurial), so thanks for your patience.

Andrew

On Fri, Jan 22, 2016 at 4:59 PM, Jim Garlick notifications@github.com
wrote:

Nice! Couple fixes needed:

  • The kvm.dev needs its specification name changed to "kvm". Its
    header comment says its for ssh too.
  • The new dev files should be added to etc/Makefile.am

If you can fix those, rebase, and force a push, I think this can go in.

Thanks!


Reply to this email directly or view it on GitHub
#8 (comment).

@garlick
Copy link
Member

garlick commented Jan 26, 2016

No prob! I'd like to have those squashed together into one commit so that powerman's commit history doesn't include the commit-that-needs-fixing + fix; it should be done right in the first commit The way to to do that is with an interactive rebase, e.g.

git rebase -i HEAD~2
# in editor, replace 'pick' with 'f' on last commit (Finalized kvs files)

Then you'll have to force a push to your branch (which will automatically update this PR)

git push -f origin kvm

@garlick garlick mentioned this pull request Jan 26, 2016
Added dev files for controlling power to virtual machines running on a
KVM (Kernel-based Virtual Machine) hypervisor, kvm.dev for a local
hypervisor and kvm-ssh for a remote hypervisor.
@adduty
Copy link
Author

adduty commented Jan 31, 2016

Sorry about the delay. Should be good to go. Thanks for your help!

On Tue, Jan 26, 2016 at 7:13 AM, Jim Garlick notifications@github.com
wrote:

No prob! I'd like to have those squashed together into one commit so that
powerman's commit history doesn't include the commit-that-needs-fixing +
fix; it should be done right in the first commit The way to to do that is
with an interactive rebase, e.g.

git rebase -i HEAD~2

in editor, replace 'pick' with 'f' on last commit (Finalized kvs files)

Then you'll have to force a push to your branch (which will automatically
update this PR)

git push -f origin kvm


Reply to this email directly or view it on GitHub
#8 (comment).

"He deserves death." "Deserves it! I daresay he does. Many that live
deserve death. And some that die deserve life. Can you give it to them?
Then do not be too eager to deal out death in judgment. For even the very
wise cannot see all ends."
-Frodo and Gandalf talking in The Fellowship of the Ring towards the end of
chapter 2: "The Shadow of the Past"

@garlick
Copy link
Member

garlick commented Jan 31, 2016

Thanks!

garlick added a commit that referenced this pull request Jan 31, 2016
@garlick garlick merged commit 322a74e into chaos:master Jan 31, 2016
@adduty
Copy link
Author

adduty commented Feb 1, 2016

Happy to help!

On Sun, Jan 31, 2016 at 8:33 AM, Jim Garlick notifications@github.com
wrote:

Merged #8 #8.


Reply to this email directly or view it on GitHub
#8 (comment).

"He deserves death." "Deserves it! I daresay he does. Many that live
deserve death. And some that die deserve life. Can you give it to them?
Then do not be too eager to deal out death in judgment. For even the very
wise cannot see all ends."
-Frodo and Gandalf talking in The Fellowship of the Ring towards the end of
chapter 2: "The Shadow of the Past"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants