add test deb packaging and fix misc build problems #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: the project version is parsed without stripping a leading 'v', causing problems for debbuild. Strip out the 'v' in the AC_INIT scriptlet as we do on other projects.
Problem: snapshot packaging makes testing the installed powerman less messy on the test system. Add a 'make deb' target to build packages in debbuild, borrowing heavily from Mark Grondona's work in flux-framework.
Problem: installing build dependencies is an irritating iterative process. Add a script to install all the dependencies for debian.
Problem: vpcd used to be installed but is no longer, yet it still has a man page. Remove man page.
Problem: autogen.sh moves aclocal.m4, which triggers a rebuild and rerun of configure in maintainer mode. Just copy over flux-core's autogen.sh as it contains some other improvements as I recall.
Problem: libtool is used to build the installed libpowerman library, but not convenience libraries which could lead to problems. Right now the API is disjoint from the rest of powerman but if it were to use convenience libraries, we could run into trouble with non-PIC code. Use libtool for the whole project.
chu11
approved these changes
Jan 25, 2024
debian/copyright
Outdated
| Files: * | ||
| Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ | ||
| Upstream-Name: bramble | ||
| Source: <https://github.com/worlickwerx/pi-cluster-two> |
There was a problem hiding this comment.
should be the source of powerman?
debian/control
Outdated
| libcurl4-gnutls-dev, | ||
| libgenders-dev | ||
|
|
||
| Homepage: https://github.com/worlickwerx/pi-cluster-two |
|
Pushed a fix for those (embarassing) errors. I've tested this on my test system and looks good. This isn't meant to be used beyond simple testing so I think the bar is pretty low as far as compliance with debian's many rules. I'll go ahead and set MWP. |
|
Oh crap, non-linear history again. Does mergify need something configured a bit different? |
|
Oh the time is messed up on this test box, never mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
make debtarget which builds a deb package from the current source tree, handy for testing.Along the way I found a few problems and tossed in fixes for those too.