systemd: allow group to be configured and set SHELL in env; add UBNT edge device #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chu11
approved these changes
Jan 26, 2024
Powerman may need to run things to connect to power control devices, such as an ssh command. For ssh to operate properly it needs to have SHELL set to a valid shell in it's environment. Note from @garlick: this was submitted in 2017 as pr chaos#24 but was left unmerged due to pending git machinations. Let's just pull it in.
The powerman.service file has configuration options to run the daemon as a specific user and group. The current default for both is "daemon". Changing the user is possible through --with-user= configure option, but there is no option for changing the group. In order to allow the group value to be configured at build time, a configure option similar to the --with-user= option should be provided. This change creates the --with-group= option, setting the @RUN_AS_GROUP@ macro for autoconf files. Note from @garlick: this was submitted in 2017 as pr chaos#26 and sat around due to maintainer inattention. Rebasing and reviving as it's a good patch!
garlick
added a commit
to garlick/powerman
that referenced
this pull request
Feb 1, 2024
Problem: ac_runas.m4 uses the deprecated AC_HELP_STRING macro. This was accidentally added by chaos#96, after other autoconf modernization changes had been merged. Update to AS_HELP_STRING.
garlick
added a commit
to garlick/powerman
that referenced
this pull request
Feb 1, 2024
Problem: ac_runas.m4 uses the deprecated AC_HELP_STRING macro. This was accidentally added by chaos#96, after other autoconf modernization changes had been merged. Update to AS_HELP_STRING.
chu11
pushed a commit
to chu11/powerman
that referenced
this pull request
Apr 4, 2024
Problem: ac_runas.m4 uses the deprecated AC_HELP_STRING macro. This was accidentally added by chaos#96, after other autoconf modernization changes had been merged. Update to AS_HELP_STRING.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revives and rebases three single-commit PRs that have been sitting a really long time. Presumably authors have moved on. If not, perhaps mentioning the PRs will elicit a response :-)
Really sorry this project was not well maintained during the period of your contribution! We'll try to do better.
Closes #26
Closes #24
Closes #48