Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release fix #2141

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Release fix #2141

merged 2 commits into from
Jan 24, 2023

Conversation

ABrain7710
Copy link
Contributor

Signed commits

  • Yes, I signed my commits.

ABrain7710 and others added 2 commits January 23, 2023 19:35
@ABrain7710
Release fix'
6dcc8ea 
Signed-off-by: Andrew Brain <61482022+ABrain7710@users.noreply.github.com>
@IsaacMilarky
err handling
76ef675 
Signed-off-by: Isaac Milarsky <krabs@tilde.team>
@ABrain7710 ABrain7710 marked this pull request as ready for review January 24, 2023 01:39
@sgoggins sgoggins merged commit af1740a into dev Jan 24, 2023
sgoggins added a commit that referenced this pull request Jan 24, 2023
@sgoggins @ABrain7710 @IsaacMilarky
update materialized view patch with current version of dev (#2142)
5e2826c 
* Refixing this error, which got hosed in the merge yesterday:
```
Traceback (most recent call last):
  File "/home/sean/github/virtualenv/k12/lib/python3.8/site-packages/celery/app/trace.py", line 451, in trace_task
    R = retval = fun(*args, **kwargs)
  File "/home/sean/github/virtualenv/k12/lib/python3.8/site-packages/celery/app/trace.py", line 734, in __protected_call__
    return self.run(*args, **kwargs)
  File "/home/sean/github/rh-k12/augur/tasks/github/releases/tasks.py", line 15, in collect_releases
    releases_model(session, repo.repo_git, repo.repo_id)
  File "/home/sean/github/rh-k12/augur/tasks/github/releases/core.py", line 209, in releases_model
    insert_release(session, repo_id, data['owner'], release, True)
  File "/home/sean/github/rh-k12/augur/tasks/github/releases/core.py", line 89, in insert_release
    release_inf = get_release_inf(session, repo_id, release, tag_only)
  File "/home/sean/github/rh-k12/augur/tasks/github/releases/core.py", line 57, in get_release_inf
    author = name + email
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'
```

* undoing a bad fix. I fixed this last night but didn't pull to k12. Its fixed on the dev branch that's in ag3.

* correct fix.

* Missed NoneType error potential.

* Release fix (#2141)

* Release fix'

Signed-off-by: Andrew Brain <61482022+ABrain7710@users.noreply.github.com>

* err handling

Signed-off-by: Isaac Milarsky <krabs@tilde.team>

Signed-off-by: Andrew Brain <61482022+ABrain7710@users.noreply.github.com>
Signed-off-by: Isaac Milarsky <krabs@tilde.team>
Co-authored-by: Isaac Milarsky <krabs@tilde.team>

Signed-off-by: Andrew Brain <61482022+ABrain7710@users.noreply.github.com>
Signed-off-by: Isaac Milarsky <krabs@tilde.team>
Co-authored-by: Andrew Brain <61482022+ABrain7710@users.noreply.github.com>
Co-authored-by: Isaac Milarsky <krabs@tilde.team>
@IsaacMilarky IsaacMilarky deleted the release-fix branch January 31, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgoggins sgoggins sgoggins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ABrain7710 @sgoggins @IsaacMilarky