Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitlab contributors for issues #2718

Merged
merged 8 commits into from
Feb 26, 2024
Merged

Add gitlab contributors for issues #2718

merged 8 commits into from
Feb 26, 2024

Conversation

ABrain7710
Copy link
Contributor

Description

  • Add gitlab contributors for issues, issue assignees, and issue messages

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Andrew Brain <andrewbrain2019@gmail.com>
Signed-off-by: Andrew Brain <andrewbrain2019@gmail.com>
Signed-off-by: Andrew Brain <andrewbrain2019@gmail.com>
Signed-off-by: Andrew Brain <andrewbrain2019@gmail.com>
@@ -689,6 +689,51 @@ def extract_needed_contributor_data(contributor, tool_source, tool_version, data

return contributor

def extract_needed_gitlab_contributor_data(contributor, tool_source, tool_version, data_source):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
C0116: Missing function or method docstring (missing-function-docstring)


return contributor


def extract_needed_clone_history_data(clone_history_data:List[dict], repo_id:int):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
C0116: Missing function or method docstring (missing-function-docstring)


return issue_ids

def process_issue_contributors(issue, tool_source, tool_version, data_source):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
C0116: Missing function or method docstring (missing-function-docstring)

@@ -270,6 +294,7 @@ def process_gitlab_issue_messages(data, task_name, repo_id, logger, augur_db):
issue_number_to_id_map[issue.gh_issue_number] = issue.issue_id

message_dicts = []
contributors = []
message_ref_mapping_data = {}
for id, messages in data.items():

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0622: Redefining built-in 'id' (redefined-builtin)

@@ -318,3 +352,12 @@ def process_gitlab_issue_messages(data, task_name, repo_id, logger, augur_db):
augur_db.insert_data(issue_message_ref_dicts, IssueMessageRef, issue_message_ref_natural_keys)


def process_gitlab_comment_contributors(message, tool_source, tool_version, data_source):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
C0116: Missing function or method docstring (missing-function-docstring)

@@ -101,14 +101,14 @@ def primary_repo_collect_phase_gitlab(repo_git):
logger = logging.getLogger(primary_repo_collect_phase_gitlab.__name__)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0612: Unused variable 'logger' (unused-variable)

@@ -129,6 +129,19 @@ class GithubUUID(AugurUUID):
def __init__(self):
super().__init__(platform = 1)

class GitlabUUID(AugurUUID):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
C0115: Missing class docstring (missing-class-docstring)


def __init__(self):
super().__init__(platform = 2)

class UnresolvableUUID(GithubUUID):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
C0115: Missing class docstring (missing-class-docstring)

ABrain7710 and others added 2 commits February 26, 2024 08:05
Signed-off-by: Isaac Milarsky <krabs@tilde.team>
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Signed-off-by: Isaac Milarsky <krabs@tilde.team>
@@ -312,8 +312,10 @@ def process_mr_metadata(data, task_name, repo_id, logger, augur_db):
for id, metadata in data.items():

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0622: Redefining built-in 'id' (redefined-builtin)

Copy link
Contributor

@IsaacMilarky IsaacMilarky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works! LGTM

@ABrain7710 ABrain7710 merged commit 4df9bc7 into dev Feb 26, 2024
4 of 5 checks passed
@ABrain7710 ABrain7710 deleted the gitlab-contributors branch February 27, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants