Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize repo insertion and add repo src id #2929

Merged
merged 20 commits into from
Oct 15, 2024
Merged

Optimize repo insertion and add repo src id #2929

merged 20 commits into from
Oct 15, 2024

Conversation

ABrain7710
Copy link
Contributor

Signed commits

  • Yes, I signed my commits.

@@ -14,18 +14,6 @@ def cache(file=None):
return redirect(url_for('static', filename="cache"))
return redirect(url_for('static', filename="cache/" + toCacheFilename(file, False)))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
E0602: Undefined variable 'toCacheFilename' (undefined-variable)

@@ -2,7 +2,7 @@
import re
from flask_login import current_user, login_required
from augur.application.db.models import Repo, RepoGroup, UserGroup, UserRepo

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0611: Unused RepoGroup imported from augur.application.db.models (unused-import)

@@ -2,7 +2,7 @@
import re
from flask_login import current_user, login_required
from augur.application.db.models import Repo, RepoGroup, UserGroup, UserRepo
from augur.tasks.frontend import add_org_repo_list, parse_org_and_repo_name, parse_org_name
from augur.tasks.frontend import add_github_orgs_and_repos, parse_org_and_repo_name, parse_org_name, add_gitlab_repos
from .utils import *
from ..server import app
from augur.application.db.session import DatabaseSession

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0611: Unused DatabaseSession imported from augur.application.db.session (unused-import)

add_existing_repo_to_group(logger, session, group_id, repo.repo_id)
continue

add_github_repo(logger, session, url, repo_group_id, group_id, repo_src_id)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
E1120: No value for argument 'repo_src_id' in function call (no-value-for-parameter)


def add_gitlab_repo(session, url, repo_group_id, group_id):

repo_id = Repo.insert_gitlab_repo(session, url, repo_group_id, "Frontend")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
E1120: No value for argument 'repo_src_id' in staticmethod call (no-value-for-parameter)

@@ -1,9 +1,18 @@
import logging
import re
import sqlalchemy as s

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0611: Unused sqlalchemy imported as s (unused-import)

@sgoggins sgoggins merged commit c2b9394 into dev Oct 15, 2024
7 of 9 checks passed
@ABrain7710 ABrain7710 deleted the unique-repos branch December 3, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants