[tasks] fix: undefined variable 's' in start_tasks.py#3607
Closed
atheendre130505 wants to merge 1 commit intochaoss:mainfrom
Closed
[tasks] fix: undefined variable 's' in start_tasks.py#3607atheendre130505 wants to merge 1 commit intochaoss:mainfrom
atheendre130505 wants to merge 1 commit intochaoss:mainfrom
Conversation
The variable 's' (sqlalchemy) was undefined in start_tasks.py, causing a NameError in cleanup tasks. Imported 'sqlalchemy as s' to fix. Signed-off-by: atheendre130505 <atheendreramesh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variable 's' (sqlalchemy) was undefined in start_tasks.py, causing a NameError in cleanup tasks. Imported 'sqlalchemy as s' to fix.
Description
This PR fixes a NameError in augur/tasks/start_tasks.py
where the variable s (intended as an alias for sqlalchemy) was used but never imported. The functions
retry_errored_repos() and create_collection_status_records() both call s.sql.text() to construct SQL queries, which would crash at runtime with NameError: name 's' is not defined.
Added import sqlalchemy as s to resolve the issue and allow these cleanup tasks to execute successfully.
This PR fixes #3606
Notes for Reviewers
This is a minimal, single-line fix that only adds the missing import statement
The fix has been verified by creating a test environment with mocked dependencies and successfully executing both affected functions
No other changes were made to keep the PR focused and easy to review
Signed commits
atheendre130505-atheendreramesh@gmail.com
Yes, I signed my commits.