Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Added Gitee backend support #645

Closed
wants to merge 20 commits into from

Conversation

WillemJiang
Copy link

This PR provides Gitee backend support.

@coveralls
Copy link

coveralls commented Apr 7, 2020

Coverage Status

Coverage decreased (-0.3%) to 97.483% when pulling 3d0e5e2 on WillemJiang:gitee into 5b4f848 on chaoss:master.

@valeriocos
Copy link
Member

Can you provide a couple of repos to test the backend, and also the instructions to access the API (if needed)? Thanks!

@WillemJiang WillemJiang changed the title [backend] Added Gitee backend support #644 [backend] Added Gitee backend support Apr 7, 2020
@WillemJiang
Copy link
Author

@valeriocos sure, I will create a test repo in gitee and add some comment on how to access the API.

@valeriocos
Copy link
Member

Thanks @WillemJiang

@WillemJiang
Copy link
Author

WillemJiang commented Apr 7, 2020

@valeriocos I just updated the issue #644 with the detail API calls with curl.

@sduenas
Copy link
Member

sduenas commented Apr 8, 2020

I'm also not sure if we want to integrate this into the core of perceval. I understand somebody would be interested on it but not sure how many. The main problem is to maintain this backend (and others through time), if we add it, that means that any other change we make will be supported by this backend. Also, if nobody uses it, it might get deprecated fast.

I'd be happy to explore the idea of having a program or similar to integrate new datasources but I'm not sure how.

We can think of having a separate repository for these backends (but someone else will have to maintain them at least when Perceval changes). Althought, I think the best idea would be to help people to have their own repositories where they maintain their own backends. At some point they might decide to contribute with that backend to the core and we can evaluate if is mature and stable enough to support it.

In any case, @WillemJiang, thanks for your work.

@WillemJiang
Copy link
Author

@sduenas Thanks for you comment. As Gitee provides a similar service as Github does, and it's quite popular in China. I think it's could a good addon feature for grimoirelab.

I think upstream first is a good practise in open source to save the cost of maintenance, and it's benefit for the whole ecosystem.

From my work experience of Apache Camel which has 300+ community contribute components, it doesn't add much work on the mentainer, as we have unit and integration tests to help us to spot the changes of camel-core which could have side effect on the camel components. And these components make Apache Camel more popular, as the users can easily find a handy component for their daily work.

I agree we need to give some time for the new bankend to be mature enough. Maybe we can add a contribution repo in grimorelab to host this new added backend first. If the backend is mature enough (we need to define a rule for it), we could consider to move it into the core module. At the meantime we can still encourage community contributor to contribute the new backend to grimoirelab.

@valeriocos
Copy link
Member

valeriocos commented Apr 9, 2020

Hi @WillemJiang,

I agree we need to give some time for the new bankend to be mature enough. Maybe we can add a contribution repo in grimorelab to host this new added backend first. If the backend is mature enough (we need to define a rule for it), we could consider to move it into the core module. At the meantime we can still encourage community contributor to contribute the new backend to grimoirelab.

The discussion around this issue and the proposal to have a contribution repo seem to be aligned with the discussion around another issue (#640, proposal: #640 (comment)). Please have a look and join the discussion if you want, thanks!

@valeriocos
Copy link
Member

@sduenas to avoid being stucked on the decision where to include this backend, please consider that the backend can be added it to the Perceval main repo, and then the maintainers will decide where to move it (if needed).

Signed-off-by: Willem Jiang <willem.jiang@gmail.com>
Signed-off-by: Willem Jiang <willem.jiang@gmail.com>
Signed-off-by: Willem Jiang <willem.jiang@gmail.com>
Signed-off-by: Willem Jiang <willem.jiang@gmail.com>
Signed-off-by: Willem Jiang <willem.jiang@gmail.com>
Signed-off-by: Willem Jiang <willem.jiang@gmail.com>
Signed-off-by: Willem Jiang <willem.jiang@gmail.com>
Signed-off-by: Willem Jiang <willem.jiang@gmail.com>
Signed-off-by: Willem Jiang <willem.jiang@gmail.com>
Signed-off-by: Willem Jiang <willem.jiang@gmail.com>
Signed-off-by: Willem Jiang <willem.jiang@gmail.com>
Signed-off-by: Willem Jiang <willem.jiang@gmail.com>
Signed-off-by: Willem Jiang <willem.jiang@gmail.com>
WillemJiang and others added 7 commits April 26, 2020 09:59
Signed-off-by: Willem Jiang <willem.jiang@gmail.com>
Signed-off-by: Willem Jiang <willem.jiang@gmail.com>
Signed-off-by: LinHaiming <lhming23@outlook.com>
Signed-off-by: Willem Jiang <willem.jiang@gmail.com>
Signed-off-by: Willem Jiang <willem.jiang@gmail.com>
Signed-off-by: Willem Jiang <willem.jiang@gmail.com>
Signed-off-by: Willem Jiang <willem.jiang@gmail.com>
@vchrombie
Copy link
Member

Closing this PR as per #644 (comment)

@vchrombie vchrombie closed this Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants