Recovery functionality for Git #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sduenas
requested changes
Mar 11, 2024
perceval/backends/core/git.py
Outdated
Comment on lines
339
to
341
| hashes = repo.get_commits_from_packs(packs, from_commit) | ||
| gitshow = repo.show(hashes) | ||
| commits = self.parse_git_log_from_iter(gitshow) |
There was a problem hiding this comment.
We might want to encapsulate these under a new method __fetch_from_packs(...).
tests/test_git.py
Outdated
| @@ -706,6 +706,95 @@ def test_fetch_from_file(self): | |||
| self.assertEqual(commit['category'], 'commit') | |||
| self.assertEqual(commit['tag'], 'http://example.com.git') | |||
|
|
|||
| def test_fetch_recovery(self): | |||
There was a problem hiding this comment.
The test looks great but I think you can improve it splitting in on different cases and not having everything tested on the same one.
perceval/backend.py
Outdated
| @@ -1035,6 +1035,7 @@ def __init__(self): | |||
| self.max_offset = None | |||
| self.last_offset = None | |||
| self.extras = None | |||
| self.last_search_fields = None | |||
There was a problem hiding this comment.
The summary does not contain any information related to the last commit or the last item collected. I think this field (search_fields) contains that information for all the backends and can be used later in the scheduler to identify it.
jjmerchante
force-pushed
the
recovery-git
branch
from
f0a480c
to
c52b82a
Compare
jjmerchante
force-pushed
the
recovery-git
branch
from
c52b82a
to
d93332b
Compare
This commit implements the recovery functionality in the fetch method of the Git backend, enabling the recovery of Perceval execution from a specific commit. Now, users can specify a recovery commit to start fetching commits from that point, ensuring robustness against failures. Signed-off-by: Jose Javier Merchante <jjmerchante@bitergia.com>
jjmerchante
force-pushed
the
recovery-git
branch
from
d93332b
to
2db6922
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the recovery functionality in the fetch method of the Git backend.
It also includes the last item search fields in the summary to allow recovering from the last item.