Update documentation about Kidash #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpgarcia
suggested changes
Aug 17, 2020
There was a problem hiding this comment.
Overall LGTM, please @vchrombie add a couple of minor fixes I detail inline.
That is a referenced section that comes from: https://github.com/chaoss/grimoirelab-sigils/blob/master/CONTRIBUTING.md#importing-panels So I think is not needed, but we're open to refurbishment proposals :) |
This commit updates the README.md about Kidash and adds its usage and relevant links. Signed-off-by: Venu Vardhan Reddy Tekula <venuvardhanreddytekula8@gmail.com>
vchrombie
force-pushed
the
update-kidash-info
branch
from
9c4329d to
fd05679
Compare
|
Hi @alpgarcia, I have updated it as per your suggestions. How does it look now? |
alpgarcia
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the README.md about Kidash and adds its usage and relevant links.
I found one more reference in this repository, CONTRIBUTING.md#installing-kidash. Can I update the information here too?
Please let me know if you have any suggestions for the PR.