Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix minor typos and broken links in the tutorials #117

Merged
merged 4 commits into from
Feb 21, 2020

Conversation

vchrombie
Copy link
Member

I was going through the sirmordred tutorials and found some typos. Please let me know if there are any more changes to do. 🙂

Signed-off-by: Venu Vardhan Reddy Tekula venuvardhanreddytekula8@gmail.com

@vchrombie
Copy link
Member Author

I think I caught a few more typos. Instead of making a new commit and a new PR again, maybe I will send them here itself.

I would send the patches asap.

Thanks. :)

@valeriocos
Copy link
Member

Thanks @vchrombie ! I wait for more commits then :)

Signed-off-by: Venu Vardhan Reddy Tekula <venuvardhanreddytekula8@gmail.com>
Signed-off-by: Venu Vardhan Reddy Tekula <venuvardhanreddytekula8@gmail.com>
Signed-off-by: Venu Vardhan Reddy Tekula <venuvardhanreddytekula8@gmail.com>
Signed-off-by: Venu Vardhan Reddy Tekula <venuvardhanreddytekula8@gmail.com>
@vchrombie vchrombie changed the title fix minor typos in sirmordred tutorials fix minor typos and broken links in the tutorials Feb 20, 2020
@vchrombie
Copy link
Member Author

Hi @valeriocos

I think I am done with the corrections and sent the commits accordingly. Please let me know if there is anything to revert back or anything to add more.

I have sent 4 commits accordingly. Please let me know if I have to squash all into one commit.

@valeriocos
Copy link
Member

That's perfect like this @vchrombie , thanks!

@valeriocos valeriocos merged commit 1598f70 into chaoss:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants