Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makepkg.conf.append: OPTIONS=(... !debug ...) #105

Merged
merged 1 commit into from
Feb 9, 2024
Merged

makepkg.conf.append: OPTIONS=(... !debug ...) #105

merged 1 commit into from
Feb 9, 2024

Conversation

xiota
Copy link
Contributor

@xiota xiota commented Feb 9, 2024

This PR disables the debug flag, which is the old default. Arch enables it by default in makepkg.conf since about 2024-02-06.

PedroHLC
PedroHLC approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@PedroHLC PedroHLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a big breaking change for them to add. We could re-add it once all AUR packages expect it there.

@dr460nf1r3 dr460nf1r3 merged commit 84a566c into chaotic-aur:main Feb 9, 2024
1 check passed
@dr460nf1r3
Copy link
Member

dr460nf1r3 commented Feb 9, 2024 •
edited
Loading

Deployed to ufscar, the rest needs to be updated still.
Edit: done too.

@xiota xiota deleted the pr_makepkg branch April 18, 2024 04:00
dr460nf1r3 added a commit to chaotic-cx/chaotic-manager that referenced this pull request Jun 25, 2024
@dr460nf1r3
fix(makepkg): don't generate debug packages
6cf4f01 
See chaotic-aur/toolbox#105 for details on why this is needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr460nf1r3 dr460nf1r3 dr460nf1r3 approved these changes

@PedroHLC PedroHLC PedroHLC approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiota @dr460nf1r3 @PedroHLC