Merge pull request #13656 from daviditen/array-as-vec-bug

Fix array-as-vec bug

[reviewed and suggested by @ronawho]

When freeing an array-as-vec we were passing the size of the user-level array
instead of the size of the allocated array. This lead to a crash. Implement
@ronawho's fix (slightly modified) and add @LouisJenkinsCS's test to the test system.

Resolves #13611

modules/internal/DefaultRectangular.chpl

@@ -1062,6 +1062,7 @@ module DefaultRectangular {
           chpl_call_free_func(externFreeFunc, c_ptrTo(data));
         }
       } else {
+        var freedData = false;
         if dom.dsiNumIndices > 0 || dataAllocRange.length > 0 {
           param needsDestroy = __primitive("needs auto destroy",
                                            __primitive("deref", data[0]));
@@ -1073,10 +1074,15 @@ module DefaultRectangular {
             if numElts == 0 then
               numElts = dom.dsiNumIndices;
             dsiDestroyDataHelper(data, numElts);
+            _ddata_free(data, numElts);
+            freedData = true;
           }
         }
-        const size = blk(1) * dom.dsiDim(1).length;
-        _ddata_free(data, size);
+        if !freedData {
+          const size = blk(1) * dom.dsiDim(1).length;
+          _ddata_free(data, size);
+          freedData = true;
+        }
       }
     }
 

test/runtime/configMatters/comm/bigArrayAsVec.chpl

@@ -0,0 +1,6 @@
+config const n = 8*1024*1024;
+
+var arr : [0..-1] int;
+for i in 1..n {
+  arr.push_back(i);
+}

test/runtime/configMatters/comm/bigArrayAsVec.numlocales

@@ -0,0 +1 @@
+2