Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename string.isEmptyString()? #11437

Closed
ben-albrecht opened this issue Oct 23, 2018 · 3 comments
Closed

rename string.isEmptyString()? #11437

ben-albrecht opened this issue Oct 23, 2018 · 3 comments
Assignees
@ben-albrecht
Labels
area: Language area: Libraries / Modules type: Design
Milestone
J Sprint 25

Comments

@ben-albrecht
Copy link
Member

One of these doesn't look like the rest..

  • array.isEmpty()
  • domain.isEmpty()
  • range.isEmpty()
  • string.isEmptyString()

Should string.isEmptyString() be string.isEmpty() like the others?

I am not aware of the motivation for the unique string method name here if such a motivation exists.
@ben-albrecht
Copy link
Member Author

Motivated by making breaking changes sooner than later, similar to #5041 (domain.member -> domain.contains)

Other potential changes like this are mentioned #6698.

@mppf
Copy link
Member

mppf commented Oct 23, 2018

Should string.isEmptyString() be string.isEmpty() like the others?

Makes sense to me.

@ben-albrecht ben-albrecht self-assigned this Feb 26, 2019
@dlongnecke-cray
Copy link
Contributor

This is great! string.isEmptyString() is incredibly tedious to write.

@ben-albrecht ben-albrecht mentioned this issue Mar 1, 2019
Merged
ben-albrecht added a commit that referenced this issue Mar 2, 2019
@ben-albrecht
Merge pull request #12435 from ben-albrecht/string.isEmpty
bd0e93c 
Deprecate string.isEmptyString for string.isEmpty

This PR deprecates `string.isEmptyString` for `string.isEmpty`, standardizing the interface for methods asking "is this thing empty?" in Chapel's standard library.

Closes #11437

[Reviewed by @ronawho]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ben-albrecht ben-albrecht

Labels
area: Language area: Libraries / Modules type: Design
Projects
None yet
Milestone
J Sprint 25
Development

No branches or pull requests
4 participants
@ben-albrecht @mppf @benjamin-robbins @dlongnecke-cray