Add Path.absPath, file.absPath and associated tests #12394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think the test cases you have are reasonable. The only thing that I can think of right now is a path involving a directory you don't have permissions on (like "foo/hiddenPath/../bar.txt" or something), and only because I was trying to think of weird cases. That'll be tricky to write - you'll want to take a look at the chmod tests for an example of how to make it and clean it up.
test/library/standard/Path/dlongnecke/fileAbsPath/fileAbsPath.chpl
Outdated
Show resolved
Hide resolved
lydia-duncan
approved these changes
Feb 27, 2019
|
One thing: it'd be good to include the testing you did in the PR/merge message |
ronawho
added a commit
to ronawho/chapel
that referenced
this pull request
Mar 15, 2019
Add recent annotations and backfill missing ones since last release Improvements: - minor unordered operation improvements (chapel-lang#12089) - massive single and multi-locale scan improvements (chapel-lang#12469, chapel-lang#12481) - string-ish improvements from --no-checks disabling range checks (chapel-lang#11780) - remote-record-read comm count regression and fix (chapel-lang#11629, chapel-lang#12439) - tuple-to-complex cast regression fix (chapel-lang#12429) - sparse bulk-add improvement from using radix sort (chapel-lang#12452) - memory leak regressions, fixes, and improvements (chapel-lang#12225, chapel-lang#12394, chapel-lang#12421, chapel-lang#12512, chapel-lang#12500, chapel-lang#12516, chapel-lang#12527, chapel-lang#12531, chapel-lang#12551, chapel-lang#12554, chapel-lang#12552) - minor regression for serial reductions from ExternArr (chapel-lang#11893) - mark notable reboots of chapcs machines
ronawho
added a commit
that referenced
this pull request
Mar 15, 2019
Add perf annotations for 2019-03-14 Add recent annotations and backfill missing ones since last release Improvements: - minor improvements for unordered operations (#12089) - massive single and multi-locale scan improvements (#12469, #12481) - string-ish improvements from --no-checks disabling range checks (#11780) - regression and fix for remote-record-read-copy comm count (#11629, #12439) - regression fix for tuple-to-complex cast (#12429) - sparse bulk-add improvement from using radix sort (#12452) - regressions, fixes, and improvements for leaks (#12225, #12394, #12421, #12512, #12500, #12516, #12527, #12531, #12551, #12554, #12552) Regressions: - minor regression for serial reductions from ExternArr (#11893) Misc: - mark notable reboots of chapcs machines (e.g. llvm, default)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a working version of
Path.absPath()andfile.absPath()(both in the Path module). The Python 3.7.2 POSIX implementation ofos.path.abspath()was referenced to ensure compatibility.Python's
file.nameand Chapel'sfile.pathseem to have different semantics (the former is the path used to open, the latter appears to be relative).I'd appreciate some additional tests if you can think of them, particularly for
file.absPath().Test coverage:
Thanks @lydia-duncan for the review!
Resolves #6005.