Make channel.mark() return the offset and throw if there is an error
#13312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 21, 2019 14:50
Update `channel.mark()` and `channel._mark()` to return the marked offset and throw if there is an error. Update test/release/examples/benchmarks/shootout/revcomp-fast.chpl to use the returned offset instead of calling `offset()` directly.
I used `channel.offset()` instead of `this.offset()`.
Return variable, not a call to it.
Don't treat channel._mark's return as an error code - it's an offset now.
|
Passed Linux64 paratest. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
channel.mark()andchannel._mark()to return the marked offsetand throw if there is an error.
Update test/release/examples/benchmarks/shootout/revcomp-fast.chpl to use
the returned offset instead of calling
offset()directly.Resolves #8943.