Make factory functions more consistent #14449
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates existing factory functions in the standard libraries to use
the convention
type.create()
as applicable.Resolves #14291
(Resolving that issue also requires changes in the Random module. But it
required a bit more refactor in the Random module to make similar changes.
See #14435)
Summary of changes:
createStringWith*
functions are deprecated in favor ofstring.createWith*
createBytesWith*
functions are deprecated in favor ofbytes.createWith*
newBlock*
andnewCyclic*
are deprecated in favor ofBlock*.create
andCyclic*.create
sparseDom.makeIndexBuffer
is deprecated in favor ofsparseDom.createIndexBuffer
(this is not a type method)Test: