Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make factory functions more consistent #14449

Closed

Conversation

e-kayrakli
Copy link
Contributor

@e-kayrakli e-kayrakli commented Nov 14, 2019

This PR deprecates existing factory functions in the standard libraries to use
the convention type.create() as applicable.

Resolves #14291

(Resolving that issue also requires changes in the Random module. But it
required a bit more refactor in the Random module to make similar changes.
See #14435)

Summary of changes:

  • createStringWith* functions are deprecated in favor of string.createWith*
  • createBytesWith* functions are deprecated in favor of bytes.createWith*
  • Compiler is adjusted to use these new functions while creating literals.
  • newBlock* and newCyclic* are deprecated in favor of Block*.create and
    Cyclic*.create
  • sparseDom.makeIndexBuffer is deprecated in favor of
    sparseDom.createIndexBuffer (this is not a type method)
  • A ton of pertinent changes in modules/tests.

Test:

  • standard
  • gasnet

@e-kayrakli
Copy link
Contributor Author

Current plan is to not move forward with this today: #14291 (comment).

Closing.

@e-kayrakli e-kayrakli closed this Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standard library factory functions are not consistent
1 participant