Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling for tryResolve and errors to handle a bad init= #14887

Merged
merged 25 commits into from
Feb 18, 2020
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
f2258ea
Improve handling for tryResolve and errors to handle a bad init=
mppf Feb 11, 2020
f5e747c
make-owned-in-for-expr.chpl uses nilable owned
mppf Feb 11, 2020
6578b4a
Fix problem with zero-arg range init and partial init
mppf Feb 12, 2020
5156b86
Move ast location to its own header and .cpp
mppf Feb 12, 2020
ccfa90f
Fix up erroneous copies
mppf Feb 12, 2020
ed38433
Save user instantiation point astloc in FnSymbol, TypeSymbol
mppf Feb 12, 2020
b72fda5
Always pass instantiationPoint to AggregateType::getInstantiation
mppf Feb 12, 2020
318e967
Fix line number for no-copy-init error on array
mppf Feb 12, 2020
66e9740
Add future for issue #14896
mppf Feb 12, 2020
548045c
Fix bugs in compiler changes
mppf Feb 12, 2020
1192883
Adjust chameneous variants to work around issue #14896
mppf Feb 12, 2020
9c6d108
Refactor implementation of PRIM_IS_COPYABLE etc
mppf Feb 13, 2020
215d314
Remove checkWithin from resolveUninsertedCall
mppf Feb 13, 2020
4759729
Set instantiationPoint for tuple TypeSymbols
mppf Feb 13, 2020
ecc104c
Fix a comment
mppf Feb 13, 2020
ffadd38
Fix errors for variable initialization from a type
mppf Feb 13, 2020
17fcb8b
Split constAndParamInHeader.chpl into different cases
mppf Feb 13, 2020
52169c1
Revert "Fix problem with zero-arg range init and partial init"
mppf Feb 13, 2020
9711a19
Fix another chameneous variant to workaround issue #14896
mppf Feb 13, 2020
67364d5
Fix .bad files after reverting zero-arg range change
mppf Feb 13, 2020
b298ffe
Report the user error for erroneous copy-inits
mppf Feb 13, 2020
0c381bf
Un-future paramInHeader tests (current error is OK)
mppf Feb 13, 2020
b659cc5
Improve comment
mppf Feb 18, 2020
a9620d2
Fix new future .good and .bad files
mppf Feb 18, 2020
b4851d9
Adjust .bad to include additional error
mppf Feb 18, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Set instantiationPoint for tuple TypeSymbols
See e.g. test/library/standard/Map/testIterators.chpl which
failed before this change, because the '=' resolved in the array
initializer was not getting the correct instantiation point for the type.
mppf committed Feb 18, 2020
commit 47597294517bc4ee370eb4f30fdfc8e457353339
1 change: 1 addition & 0 deletions compiler/resolution/tuples.cpp
Original file line number Diff line number Diff line change
@@ -373,6 +373,7 @@ TupleInfo getTupleInfo(std::vector<TypeSymbol*>& args,
// Create the TypeSymbol
TypeSymbol* newTypeSymbol = new TypeSymbol(name.c_str(), newType);
newTypeSymbol->cname = astr(cname.c_str());
newTypeSymbol->instantiationPoint = instantiationPoint;

// Set appropriate flags on the new TypeSymbol
newTypeSymbol->addFlag(FLAG_ALLOW_REF);