Fix up chameneous benchmarks and patterns of returning array of non-nilable #15251
+86
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see e.g. test/studies/shootout/chameneos-redux/bradc/chameneosredux-blc.chpl
mppf
force-pushed
the
follow-up-chameneos
branch
from
8d46638 to
4cb92e5
Compare
mppf
changed the title
benharsh
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: PR #14887, issue #14896, PR #15240.
This PR reverts some changes to chameneos tests now that issue #14896 is
solved. Once the changes were reverted, the tests uncovered additional
problems with the erroneous-initializer logic that this PR fixes.
Reviewed by @benharsh - thanks!