chore: add deprecation warnings when casting string/bytes to regex #20944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update .good with deprecation messages for string to regex Signed-off-by: arezaii <ahmad.rezaii@hpe.com>
arezaii
force-pushed
the
deprecate-regex-to-string
branch
from
990cb1e to
6d3d5c8
Compare
mppf
reviewed
Nov 28, 2022
| @@ -1444,7 +1444,10 @@ module ChapelBase { | |||
| // string to a type. Otherwise, we can't resolve chpl_debug_writeln in | |||
| // `range.these` | |||
| { var dummyRange = 1..0; for i in dummyRange {} } | |||
| return str:t; | |||
| if t:string == "regex(string)" || t:string == "regex(bytes)" then | |||
There was a problem hiding this comment.
how about if t == regex(string) || t == regex(bytes) ?
There was a problem hiding this comment.
I attempted to make this change and ran into issues. I added some comments to document the problems encountered and noted that we would prefer to use the type comparison rather than string comparison here.
jeremiah-corrado
approved these changes
Nov 28, 2022
test/regex/bytes/cast.good
Outdated
| @@ -1,3 +1,9 @@ | |||
| cast.chpl:8: warning: Casting strings to regex is deprecated. Use regex.compile(string) instead. | |||
| cast.chpl:9: warning: Casting bytes to regex is deprecated. Use regex.compile(bytes) instead. | |||
There was a problem hiding this comment.
I might remove lines 8-15 from this test since the deprecated cast is still tested in /deprecated/regexTertiary
arezaii
force-pushed
the
deprecate-regex-to-string
branch
from
2d239f5 to
6d3d5c8
Compare
Signed-off-by: arezaii <ahmad.rezaii@hpe.com>
Signed-off-by: arezaii <ahmad.rezaii@hpe.com>
arezaii
force-pushed
the
deprecate-regex-to-string
branch
from
5bee0b5 to
4bab3aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks casts from strings or bytes to regex as deprecated and
suggests using
compile()fromRegexmodule as a replacement untilthrowing initializers are implemented and we can suggest
new regex().Updates some test
.goodfiles to expect the deprecation message.TESTING:
reviewd by @jeremiah-corrado - thanks!