Improve Python module testing and cleanup memory leaks #26353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabraham17
changed the title
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
jabraham17
force-pushed
the
python-add-leak-testing
branch
from
bf60294 to
5c0e566
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make more of the Python package module tests run more frequently. While doing this, I also cleaned up as many of the Python memory leaks in the Python module as I could find.
Some of the tests rely on external Python dependencies like torch and numba. Previously, these tests were always skipped and a "compileOnly" version was tested. This PR adds a step to the skipif to install the dependencies locally if they are missing. This allows the tests to actually be executed in more cases
This PR also adds support for checking for unfree'ed references, controlled by the
--pyMemLeaksflag. This relies on an external python dependency, so this uses similar external Python dependencies testing support as aboveTesting
start_test test/library/packages/Pythonstart_test -memleaks test/library/packages/Python[Reviewed by @]