Make sure that module scope variables of extern types are default initalized #26417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
jabraham17
force-pushed
the
fix-uninit-extern
branch
from
78feccd to
632b6e5
Compare
mppf
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where module scope variables of an extern type where not default initialized properly. This was caused by a dead store of
PRIM_ZERO_VARIABLEto a temporary, created bymakeHeapAllocationsin theparallelpass.The fix is to just set the temporary back to the "pointer"
This PR also adds a NUMLOCALES file to some C extern tests to ensure they are run in nightly gasnet+asan tests
Resolves #26406
Testing
start_testwith GASNet + ASAN tesing ontest/extern/bharshbarg/andtest/extern/ferguson/[Reviewed by @mppf]