-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to infer CHPL_LLVM_GCC_INSTALL_DIR #26429
Open
jabraham17
wants to merge
6
commits into
chapel-lang:main
Choose a base branch
from
jabraham17:infer-gcc-install-dir
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6a82b30
add ability to infer CHPL_LLVM_GCC_INSTALL_DIR
jabraham17 e97a6ef
allow CHPL_LLVM_GCC_INSTALL_DIR=none
jabraham17 cfaa9cc
cleanup logic
jabraham17 19f598f
make CHPL_LLVM_GCC_INSTALL_DIR able to be specified in a chplconfig
jabraham17 7e7b37a
undo comment change
jabraham17 57a60e2
make sure user options are respected and warnings are emitted
jabraham17 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -72,6 +72,7 @@ | |
'CHPL_LLVM_CLANG_CXX', | ||
# CHPL_LLVM_VERSION -- doesn't make sense to override it | ||
'CHPL_LLVM_GCC_PREFIX', # not in printchplenv --all | ||
'CHPL_LLVM_GCC_INSTALL_DIR', # not in printchplenv --all | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
|
||
'CHPL_AUX_FILESYS', | ||
'CHPL_LIB_PIC', | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something weird happened with this comment