Turn on -buildcheck for gpus in nightly tests
#26432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
e-kayrakli
reviewed
Dec 18, 2024
| @@ -5,4 +5,4 @@ | |||
| # set this before sourcing common-perf | |||
| export CHPL_TEST_PERF_SUBDIR='gpu' | |||
|
|
|||
| nightly_args="${nightly_args} -performance -perflabel gpu- -numtrials 5" | |||
| nightly_args="${nightly_args} -no-buildcheck -performance -perflabel gpu- -numtrials 5" | |||
There was a problem hiding this comment.
I'm OK with this as this is not a correctness config. But also curious whether there is any deep reason beyond that.
There was a problem hiding this comment.
I don't have a deep reason beyond the fact that many of the other perf configs do this
e-kayrakli
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
-no-buildcheckin all GPU configs. This is an artifact from whenmake checkdid not support GPUs, but now it does and we want to test that.This PR does maintain
-no-buildcheckin the GPU perf configs, this matches what we do for other perf configs.[Reviewed by @e-kayrakli]