Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a github action workflow to upload to PyPI #57

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Add a github action workflow to upload to PyPI #57

merged 1 commit into from
Mar 25, 2022

Conversation

ronawho
Copy link
Collaborator

@ronawho ronawho commented Mar 25, 2022

Previously, we would manually run util/release.bash to tag a new
release and upload it to PyPI. This required having local PyPI
credentials and being careful that your branches were all up to date.

This adds a github action to simplify and automate release creation.
When a new release is created (or if manually started) the job will run
testing and if that passes will then create the release and upload it.
We run the test and build/upload steps in separate jobs to ensure we
have a clean environment for the upload. And note that testing manually
installs the package and runs pytest instead of using tox, just to make
sure that things work from a user perspective and there's no
dependencies that are listed in tox, but not setup.py.

By default this will upload to the official pypi repo and authentication
is done with a secret token. To test releases, there is also an option
to upload to test.pypi.

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #57 (dba6437) into main (89695e0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   40.79%   40.79%           
=======================================
  Files           2        2           
  Lines         527      527           
=======================================
  Hits          215      215           
  Misses        312      312           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89695e0...dba6437. Read the comment docs.

Previously, we would manually run `util/release.bash` to tag a new
release and upload it to PyPI. This required having local PyPI
credentials and being careful that your branches were all up to date.

This adds a github action to simplify and automate release creation.
When a new release is created (or if manually started) the job will run
testing and if that passes will then create the release and upload it.
We run the test and build/upload steps in separate jobs to ensure we
have a clean environment for the upload. And note that testing manually
installs the package and runs pytest instead of using tox, just to make
sure that things work from a user perspective and there's no
dependencies that are listed in tox, but not setup.py.

By default this will upload to the official pypi repo and authentication
is done with a secret token. To test releases, there is also an option
to upload to test.pypi.
@ronawho ronawho requested a review from lydia-duncan March 25, 2022 21:21
@ronawho ronawho merged commit be783b3 into chapel-lang:main Mar 25, 2022
@ronawho ronawho deleted the add-pypi-upload-action branch March 25, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants