Update the version and add a note to the requirements file #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version update is the usual post-release version bump so that we are ready for the next one. The requirements file note is so that we don't forget to update setup.py the next time we update the requirements.txt file. We had previously removed the version numbers from setup.py under the mistaken belief that setting it in the requirements file was sufficient to affect what was used when calling setup.py. However, that was not the case in the independent release job, so it needed the version numbers restored ---- Signed-off-by: Lydia Duncan <lydia-duncan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version update is the usual post-release version bump so that we are ready
for the next one.
The requirements file note is so that we don't forget to update setup.py the
next time we update the requirements.txt file. We had previously removed the
version numbers from setup.py under the mistaken belief that setting it in the
requirements file was sufficient to affect what was used when calling setup.py.
However, that was not the case in the independent release job, so it needed the
version numbers restored
Signed-off-by: Lydia Duncan lydia-duncan@users.noreply.github.com