Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize where clauses #72

Merged
merged 8 commits into from
Jun 20, 2023
Merged

Recognize where clauses #72

merged 8 commits into from
Jun 20, 2023

Conversation

nikkirad
Copy link
Contributor

@nikkirad nikkirad commented Jun 8, 2023

Modified the regular expression chpl_sig_pattern and added functionality to recognize where clauses.

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 11.11% and project coverage change: -0.56 ⚠️

Comparison is base (0c164bd) 42.96% compared to head (851c35b) 42.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   42.96%   42.40%   -0.56%     
==========================================
  Files           2        2              
  Lines         533      540       +7     
==========================================
  Hits          229      229              
- Misses        304      311       +7     
Impacted Files Coverage Δ
sphinxcontrib/chapeldomain/__init__.py 40.64% <11.11%> (-0.56%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@lydia-duncan lydia-duncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This looked tricky, just a few suggestions and questions

test/test_chapeldomain.py Show resolved Hide resolved
test/test_chapeldomain.py Show resolved Hide resolved
test/test_chapeldomain.py Show resolved Hide resolved
test/test_chapeldomain.py Show resolved Hide resolved
nikkirad added 2 commits June 15, 2023 13:09
Raise a ValueError if we a non-proc-like directive contains a where_clause that is set to something other than None.
@nikkirad nikkirad requested a review from lydia-duncan June 15, 2023 20:20
Copy link
Member

@lydia-duncan lydia-duncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@nikkirad nikkirad merged commit 1d6b2ce into chapel-lang:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants