Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signature regex to match more possible operator names #78

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

jabraham17
Copy link
Member

Fixes a bug where operator names would not be displayed correctly and where not linkable (chapel-lang/chapel#17057). This was due to the chpl signature regex not matching all possible operators like ~ or |.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fc0e562) 42.25% compared to head (f60f18e) 42.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #78   +/-   ##
=======================================
  Coverage   42.25%   42.25%           
=======================================
  Files           2        2           
  Lines         542      542           
=======================================
  Hits          229      229           
  Misses        313      313           
Files Changed Coverage Δ
sphinxcontrib/chapeldomain/__init__.py 40.49% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
@lydia-duncan lydia-duncan self-requested a review August 16, 2023 20:27
Copy link
Member

@lydia-duncan lydia-duncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on, looks good to me!

@jabraham17 jabraham17 merged commit d21c51e into chapel-lang:main Aug 16, 2023
@jabraham17 jabraham17 deleted the fix-operator-names branch August 16, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants