Fix links for nested types #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
- Coverage 42.07% 41.59% -0.49%
==========================================
Files 2 2
Lines 549 553 +4
==========================================
- Hits 231 230 -1
- Misses 318 323 +5 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
jabraham17
added a commit
to chapel-lang/chapel
that referenced
this pull request
Mar 12, 2024
This PR pulls in a fix from sphinxcontrib-chapeldomain that fixes how links for nested types are rendered. This PR also adds a test for chpldoc to lock in the correct behavior. See chapel-lang/sphinxcontrib-chapeldomain#90 for details of the fix [Reviewed by @lydia-duncan]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the handling of class names to correctly create links for nested types.
See
doc-test/nested.rstfor an example. PreviouslyMyMod.TopLevel.bazwould incorrectly be linked asMyMod.baz[Reviewed by @lydia-duncan]