This repository has been archived by the owner on Jun 15, 2023. It is now read-only.
Fixing composer issue where it doesn't respect check() always disposes #781
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chaplin's composer is not respecting the check method and is always disposing regardless. Simply using the check method to determine if a composition is stale or not works great for me.
The long form example here: http://docs.chaplinjs.org/chaplin.composer.html does not work as described before this PR.