Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chaquopy-ffmpeg package #1128

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

macmegan
Copy link

@macmegan macmegan commented Apr 2, 2024

@mhsmith
Copy link
Member

mhsmith commented Apr 4, 2024

Thanks, I'll have a look at this as soon as I can.

You mentioned #1012: does that mean you've successfully built av as well? If so, please create another PR for that.

@mhsmith
Copy link
Member

mhsmith commented Oct 26, 2024

Sorry for taking so long to look at this.

Even if this recipe builds the ffmpeg library, the test doesn't verify that the library actually works, because all it does is construct a command line without executing it.

Also, ffmpeg-python's documentation clearly says that it calls ffmpeg as an executable on the PATH, which wouldn't work on Android anyway (#605). So a different testing approach would be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants