-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Shapely to 2.0.6 #1274
base: master
Are you sure you want to change the base?
Update Shapely to 2.0.6 #1274
Conversation
I think the main step you missed was to actually test your changes. The build-wheel tool now installs Also, unless there's a specific reason, which should be explained with a comment, the NumPy versions should follow the same pattern as the other packages that use it, such as Pandas and Matplotlib. |
I had updated numpy since there's a more up-to-date copy available in the Chaquopy package index. I can revert that change though! |
- Revert numpy version change - Remove build requirements now that the build-wheel tool can install build-system requirements from a pyproject.toml file
@mhsmith, updated the PR. I reverted the numpy change and removed the cython requirement. |
Building against a library at compile time means that you must use that version or newer at runtime. So to give as much flexibility as possible, it's better to build against older versions where feasible. |
The build still doesn't work, because the patch doesn't apply to the new version:
In all GitHub projects, you are expected to test PRs before submitting them. Please follow the instructions in server/pypi/README.md to build and test the new Shapely version, and update the recipe as necessary. You don't have to cover all combinations of Python version and ABI, but you do have to get at least one working, and let me know what it was. |
This updates Shapely to the latest version! Please let me know if I missed any steps!
Closes #1269