Fix namespace collision on newer setuptools #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On setuptools >= 19.3 installation failed due to relative imports being handled differently. Importing `http.client` was supposed to import the standard library HTTP client, but was instead importing this package's `http` module.
vaiporwal
added a commit
that referenced
this pull request
Mar 16, 2016
Namespace collision for 'http' with Python dependency setuptools is fixed. See pull request: #9
|
We have fixed this issue in latest release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setuptools>= 19.3 updated the way that paths are handled, causing a collision betweenchargebee.httpandhttp.client(within the context of thechargebeepackage). I believe7de983b7 was the breaking commit.
This came about because Heroku's Python buildpack recently updated to
setuptools==19.6, causing all installations to fail on all (new) Heroku apps (see heroku/heroku-buildpack-python@b1d1a7c).The solution here is to rename
charegbee.http. In this PR, I've renamed it tochargebee.http_request, which is a little more verbose, but prevents installation failures (confirmed on Python 3.4.x withsetuptools19.3, 19.4, 19.5 and 19.6). I'd be happy to change it to something else if desired.Thanks!