Fix false positive (#21)

charithe · Oct 9, 2021 · c941235 · c941235
1 parent ec9cf88
commit c941235
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/durationcheck.go b/durationcheck.go
@@ -150,6 +150,9 @@ func isAcceptableNestedExpr(pass *analysis.Pass, n ast.Expr) bool {
 	case *ast.Ident:
 		return isAcceptableIdent(pass, e)
 	case *ast.CallExpr:
+		if isAcceptableCast(pass, e) {
+			return true
+		}
 		t := pass.TypesInfo.TypeOf(e)
 		return !isDuration(t)
 	case *ast.SelectorExpr:

diff --git a/testdata/src/a/a.go b/testdata/src/a/a.go
@@ -74,6 +74,8 @@ func validCases() {
 	_ = time.Second * b.SomeInt
 
 	_ = time.Duration(intArr[0]) * time.Second
+
+	_ = time.Duration(y) * 24 * time.Hour
 }
 
 func invalidCases() {