Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive when multiplying with two constants #1

Closed
reillywatson opened this issue Feb 19, 2019 · 3 comments
Closed

False positive when multiplying with two constants #1

reillywatson opened this issue Feb 19, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@reillywatson
Copy link

Sample code:

package dur

import "time"

const TwoDays = 2 * 24 * time.Hour

Outputs: "dur.go:5:17: Multiplication of durations: 2 * 24 * time.Hour"

@charithe
Copy link
Owner

Thanks! I have a fix for this and the other case you raised but I need to clean up the code a bit more before I am happy to release it.

@reillywatson
Copy link
Author

Awesome! Thanks for the nice tool, I've seen this bug before and am happy to have it never happen again :)

charithe pushed a commit that referenced this issue Feb 20, 2019
@charithe
Copy link
Owner

I am glad that you find it useful and thanks for the bug report.

This issue has been fixed.

@charithe charithe added the bug Something isn't working label Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants