Add native targets #579
Merged
Add native targets #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 22, 2024
|
Hi, @charleskorn. Could you please take a look at the PR? |
charleskorn
reviewed
Jun 23, 2024
buildSrc/src/main/kotlin/com/charleskorn/kaml/build/ConfigureAssemble.kt
Outdated
Show resolved
Hide resolved
charleskorn
reviewed
Jun 23, 2024
OptimumCode
force-pushed
the
native-targets
branch
2 times, most recently
from
55c5564 to
732c4cd
Compare
charleskorn
reviewed
Jun 29, 2024
OptimumCode
force-pushed
the
native-targets
branch
from
e3e780b to
0dc5203
Compare
|
@charleskorn Should I add a concurrency group to prevent multiple workflows from running for the same PR? |
charleskorn
reviewed
Jun 30, 2024
Yep, sounds like a good idea. |
…sumption after adding native targets
OptimumCode
force-pushed
the
native-targets
branch
from
ba25e0d to
7cb1140
Compare
OptimumCode
commented
Jun 30, 2024
|
KT-69327 should be resolved in Kotlin 2.1.0 based on the latest comment in the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem with saving test results for native target - this issue will probably be resolved after #574 is merged.
There are also two tests failed (for invalid floating point with input
1e+and1e-- the problem was reported to Kotlin team in KT-69327).Resolves #232
Please, let me know if I have missed something