fastwalk: add optional sorting and improve documentation #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlievieth
force-pushed
the
cev/sort-new
branch
7 times, most recently
from
c1c80ff
to
9d9b117
Compare
This commit adds the new SortMode and Config.Sort setting to sort a directory's entries before they are processed. This does not make the global order that directories and entries are visited non-deterministic but it does help make the output a bit saner compared to the default directory order. This was added to make the output of FZF a bit nicer. This commit also improves documentation and comments of exported functions.
charlievieth
force-pushed
the
cev/sort-new
branch
from
9d9b117
to
18d517e
Compare
charlievieth
changed the title
charlievieth
added a commit
to charlievieth/fzf
that referenced
this pull request
Jul 18, 2024
This commit updates github.com/charlievieth/fastwalk to v1.0.7 which improves MSYS detection and adds optional sorting of directory entries. It also updates fzf to use the SortFilesFirst sort mode which improves the output by making it a bit more sorted and grouped by directory previously entries were visited in directory order (which is basically random). PRs Included: * charlievieth/fastwalk#25 * charlievieth/fastwalk#27 * charlievieth/fastwalk#28
charlievieth
added a commit
to charlievieth/fzf
that referenced
this pull request
Jul 18, 2024
This commit updates github.com/charlievieth/fastwalk to v1.0.8 which improves MSYS detection and adds optional sorting of directory entries. It also updates fzf to use the SortFilesFirst sort mode which improves the output by making it a bit more sorted and grouped by directory previously entries were visited in directory order (which is basically random). PRs Included: * charlievieth/fastwalk#25 * charlievieth/fastwalk#27 * charlievieth/fastwalk#28
charlievieth
added a commit
to charlievieth/fzf
that referenced
this pull request
Jul 18, 2024
This commit updates github.com/charlievieth/fastwalk to v1.0.8 which improves MSYS detection and adds optional sorting of directory entries. It also updates fzf to use the SortFilesFirst sort mode which improves the output by making it a bit more sorted and grouped by directory previously entries were visited in directory order (which is basically random). PRs Included: * charlievieth/fastwalk#25 * charlievieth/fastwalk#27 * charlievieth/fastwalk#28
junegunn
pushed a commit
to junegunn/fzf
that referenced
this pull request
Jul 19, 2024
This commit updates github.com/charlievieth/fastwalk to v1.0.8 which improves MSYS detection and adds optional sorting of directory entries. It also updates fzf to use the SortFilesFirst sort mode which improves the output by making it a bit more sorted and grouped by directory previously entries were visited in directory order (which is basically random). PRs Included: * charlievieth/fastwalk#25 * charlievieth/fastwalk#27 * charlievieth/fastwalk#28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the new SortMode and Config.Sort setting to sort directory entries before they are processed. This does not make the global order that directories and entries are visited non-deterministic but it does help make the output a bit saner compared to the default directory order. It might also have some performance benefits in some use-cases. This was added to make the output of FZF and other tools that print the output of fastwalk a bit nicer.
This commit also improves documentation and comments of exported functions.