Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup tests on 32-bit #32

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Fixup tests on 32-bit #32

merged 1 commit into from
Aug 31, 2024

Conversation

nileshpatra
Copy link
Contributor

Tests on 32-bit fail with:

github.com/charlievieth/fastwalk/internal/dirent github.com/charlievieth/fastwalk/internal/fmtdirent
108s # github.com/charlievieth/fastwalk_test [github.com/charlievieth/fastwalk.test]
108s src/github.com/charlievieth/fastwalk/fastwalk_test.go:962:48: cannot use math.MaxUint32 (untyped int constant 4294967295) as int value in argument to fmt.Sprintf (overflows)

@nileshpatra
Copy link
Contributor Author

/cc: @charlievieth

charlievieth
charlievieth approved these changes Aug 31, 2024
View reviewed changes
Copy link
Owner

@charlievieth charlievieth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this!

@charlievieth charlievieth merged commit 0131e8e into charlievieth:master Aug 31, 2024
10 checks passed
@charlievieth
Copy link
Owner

I'm going to update the GH actions this weekend so that we run the tests for GOARCH 386 (32bit). Let me know if you need a release cut.

charlievieth added a commit that referenced this pull request Aug 31, 2024
@charlievieth
gh: test fastwalk on 32-bit (386) Linux
a01b7c5 
#32
@charlievieth charlievieth mentioned this pull request Aug 31, 2024
Merged
charlievieth added a commit that referenced this pull request Aug 31, 2024
@charlievieth
gh: test fastwalk on 32-bit (386) Linux
5a4b570 
#32
@charlievieth
Copy link
Owner

Added 32-bit tests in CI to prevent this from happening in the future: #33

@nileshpatra nileshpatra deleted the fix-32-bit branch September 22, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlievieth charlievieth charlievieth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nileshpatra @charlievieth