Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a DB migration to add params to schema. #245

Merged
merged 1 commit into from
Jun 2, 2017

Conversation

rposborne
Copy link
Contributor

@rposborne rposborne commented May 26, 2017

Might need to add a note to the readme.

@jgrau
Copy link
Contributor

jgrau commented May 26, 2017

Thanks @rposborne. The migration files in the upgrade_migrations directory have been a source of confusion to me. Mainly

  • how do I run a migration in a specific directory
  • the files are named with the version number but are they run run automatically on updates
  • are the name of the files the version you update FROM or TO

I suspect other devs might be confused about this as well.

Adding this file is a good addition and I will merge it no matter what, but if you're up for adding text to the readme regarding this file and how it works then I would much appreciate it. Let me know if you don't have the time for that and we'll just merge this as is.

@rposborne
Copy link
Contributor Author

@jgrau There are a few hints in the changelog that point out that these were expected to be running manually... I guess specifying the explicit migration.

It looks like there are a handful of better patterns for this. Either adding the migrations to the migration load path or copying them over via a generator. As this stands now, having a record of this in the repo I think is a win, but ideally we should wire up a way to make the upgrade process more streamlined.

Copy link
Contributor

@jgrau jgrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and the research on better ways to handle this. I've added this as a feature request #247

@jgrau jgrau merged commit 513cd7d into charlotte-ruby:master Jun 2, 2017
@rposborne rposborne deleted the db-upgrade branch June 2, 2017 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants