Delegate Cursor Logic to cursor bubble
#181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaslalani
commented
Jun 28, 2022
| // Cursor returns the cursor position. | ||
| func (m Model) Cursor() int { | ||
| // Position returns the cursor position. | ||
| func (m Model) Position() int { |
There was a problem hiding this comment.
Cursor for the cursor.Model.
maaslalani
force-pushed
the
input-cursor
branch
3 times, most recently
from
3a66598
to
80324e5
Compare
maaslalani
force-pushed
the
input-cursor
branch
from
dc88246
to
be3984b
Compare
ReallyLiri
pushed a commit
to ReallyLiri/bubbles
that referenced
this pull request
Jun 13, 2024
* refactor: remove cursor logic from textinput * chore: Add Deprecated Fields to avoid breaking changes * fix: Ctrl+A and typing moves to end bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the original cursor logic to the cursor bubble.