-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose TotalLineCount() and VisibleLineCount() methods within viewport #283
Conversation
Thanks, @adaam2. Per the discussion:
Just curious about your use case here: is there a particular reason you need the actual lines versus just the total number? Was assuming this PR would be something closer to something like this: func (m Model) TotalLineCount() int
func (m Model) VisibleLineCount() int |
@meowgorithm yeah I'd be happy with just the totals - figured the actual content of the lines may have been more useful for others going forward (maintaining snapshots of content etc, but then again could just capture that in other ways just as easily) I'll change the PR unless you have had a change of heart. |
@adaam2 Thank you! For now, let's just stick with the totals. Just a couple small requests, then we're good to go with this one. |
@meowgorithm updated 👍🏻 |
Looks good. Thank you! |
As per discord discussion, exposes a
TotalLineCount()
andVisibleLineCount()
methods in the viewport package.