feat: method for determining if progress bar is animating #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrashk
force-pushed
the
progress-is-complete
branch
from
b8c581e
to
31b3237
Compare
|
This specifically to check that the progress bar is not animating, correct? If so, |
meowgorithm
reviewed
Jun 13, 2023
yrashk
force-pushed
the
progress-is-complete
branch
from
31b3237
to
ca4e11b
Compare
|
Renamed to |
This would be useful to know to stop displaying it after the user was shown the progress bar to render to its end. Solution: expose `IsComplete` method is based on what's been drawn
yrashk
force-pushed
the
progress-is-complete
branch
from
ca4e11b
to
5fcaf2b
Compare
|
Look good. Thank you! |
|
Thanks! What's your release-cutting cadence/policy? |
|
We probably won’t cut a new release for a bit, but in the meantime you can pin to |
meowgorithm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be useful to know to stop displaying it after the user was shown the progress bar to render to its end.
Solution: expose
IsCompletemethod is based on what's been drawn