(fix)textInput: Placeholder View now respects set Width, Paste Fix #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Available length calculation now correctly trims pasted text.
When `placeholder` is set, padding from `Width` was not added within the `placeholderView()` function.
fix(textInput): Width padding added when placeholder is used
Fix position value in padding calculation not being used (added `m.` to `pos`)
|
Hey, thank you for the PR, we merged #442! |
|
Thanks for the PR, Rose! Just closing this one to close the loop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pointed out by Discord user TooManyBison , the
placeholderView()function would not add padding to match a givenWidth.This was inconsistent with the standard
View()function, which compares the text width with the content and adds padding accordingly.This patch brings the width calculation from
View()into theplaceholderView()function, and additionally includes a minor fix when pasting text.