fix(textinput): Placeholder No Longer Changes Width + Paste Calculation #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Available length calculation now correctly trims pasted text.
When `placeholder` is set, padding from `Width` was not added within the `placeholderView()` function.
fix(textInput): Width padding added when placeholder is used
Fix position value in padding calculation not being used (added `m.` to `pos`)
|
Thank you so much @hopefulTex, just tested this out with various values for placeholder and width and it works great! Really appreciate the PR ❤️ |
maaslalani
reviewed
Dec 23, 2023
Great catch on this as well! |
maaslalani
added a commit
to prgres/bubbles
that referenced
this pull request
Feb 28, 2024
…on (charmbracelet#451) * Fix pasting calculations Available length calculation now correctly trims pasted text. * fix(textInput): Width padding added when placeholder is used When `placeholder` is set, padding from `Width` was not added within the `placeholderView()` function. * Adding missing 'm.' * Maintain Width no matter placeholder size delta * Fixed Math * Added Comments * fix: lint --------- Co-authored-by: Donovan Hubbard <37090676+donovanhubbard@users.noreply.github.com> Co-authored-by: Maas Lalani <maas@lalani.dev>
ReallyLiri
pushed a commit
to ReallyLiri/bubbles
that referenced
this pull request
Jun 13, 2024
…on (charmbracelet#451) * Fix pasting calculations Available length calculation now correctly trims pasted text. * fix(textInput): Width padding added when placeholder is used When `placeholder` is set, padding from `Width` was not added within the `placeholderView()` function. * Adding missing 'm.' * Maintain Width no matter placeholder size delta * Fixed Math * Added Comments * fix: lint --------- Co-authored-by: Donovan Hubbard <37090676+donovanhubbard@users.noreply.github.com> Co-authored-by: Maas Lalani <maas@lalani.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
placeholderView()function did not respectWidthwhen it was set to a non-zero value. The textinput's width now stays the same irrelevant of the placeholder length.Pasting now trims to match the available space if length is greater than the
charLimit.