feat: Substitute mutex with atomic operations. #622
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use atomic operations instead a mutex. This approach avoids locking and increment can be done within a single clock cycle, hence no deadlock nor race condition can occur. Signed-off-by: Ville Valkonen <weezel@users.noreply.github.com>
|
A gentle one week bump |
|
A gentle two weeks bump |
bashbunni
approved these changes
Oct 7, 2024
|
Thanks for your patience with this one @weezel. If we think this makes sense we should probably do this across the board in Bubbles where we employ this pattern (for example, in Before we merge this we should also look into why this is failing in CI. |
caarlos0
reviewed
Oct 7, 2024
Comment on lines
+22
to
+23
| lastID.Add(1) | ||
| return int(lastID.Load()) |
There was a problem hiding this comment.
add returns the new value, so this can be:
Suggested change
| lastID.Add(1) | |
| return int(lastID.Load()) | |
| return int(lastID.Add(1)) |
|
caarlos0
added a commit
that referenced
this pull request
Oct 7, 2024
closes #622 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
caarlos0
added a commit
that referenced
this pull request
Oct 7, 2024
closes #622 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
|
Unless there are any negative implications, let’s maintain 1.18 compatibility. |
caarlos0
added a commit
that referenced
this pull request
Oct 7, 2024
closes #622 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> Co-authored-by: Ville Valkonen <weezel@users.noreply.github.com>
caarlos0
added a commit
that referenced
this pull request
Oct 7, 2024
closes #622 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> Co-authored-by: Ville Valkonen <weezel@users.noreply.github.com>
|
Thanking you 😊👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use atomic operations instead a mutex. This approach avoids locking and increment can be done within a single clock cycle, hence no deadlock nor race condition can occur.